Skip to content

Add kickstart tests for stratis autopart - #1691

Open
vojtechtrefny wants to merge 1 commit into
rhinstaller:mainfrom
vojtechtrefny:main_stratis-autopart
Open

Add kickstart tests for stratis autopart#1691
vojtechtrefny wants to merge 1 commit into
rhinstaller:mainfrom
vojtechtrefny:main_stratis-autopart

Conversation

@vojtechtrefny

Copy link
Copy Markdown
Contributor

Both plain and encrypted layout. Libguestfs does not support stratis so we copy the logs to /boot so we can extract it later.

Needs pykickstart/pykickstart#584 and not yet released Anaconda and Blivet changes.

@rvykydal

Copy link
Copy Markdown
Contributor

If you care you can update the tests to use fragments as some of our newer tests do, but I created a task https://redhat.atlassian.net/browse/INSTALLER-4856 for it and we can do it in scope of the task.

@rvykydal

Copy link
Copy Markdown
Contributor

I guess you can share the code in the two .sh files similarly as validate_stratis in #1728.

@vojtechtrefny
vojtechtrefny force-pushed the main_stratis-autopart branch from aed5e39 to 64d9f56 Compare August 11, 2026 12:57
@vojtechtrefny

Copy link
Copy Markdown
Contributor Author

/test-os-variants

Comment thread autopart-stratis.ks.in
fi
%end

%post --nochroot

@rvykydal rvykydal Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pita, but could we maybe move this to post-nochroot-lib-storage.sh and share?
(The current organic "post-*-lib- structure" is ugly, but I think we want to have it on single place. Maybe even create post-nochroot-lib.sh for that.)
Other than that looks great.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, done.

Both plain and encrypted layout. Libguestfs does not support
stratis so we copy the logs to /boot so we can extract it later.
@vojtechtrefny
vojtechtrefny force-pushed the main_stratis-autopart branch from 64d9f56 to 1afe9ab Compare August 13, 2026 10:40

@rvykydal rvykydal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@rvykydal

Copy link
Copy Markdown
Contributor

/test-os-variants --os-variants daily-iso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants